Update the payment intent when save is unselected. #4291
Conversation
| sealed class New : PaymentSelection() { | ||
| abstract val paymentMethodCreateParams: PaymentMethodCreateParams | ||
| abstract val shouldSavePaymentMethod: Boolean |
There was a problem hiding this comment.
iOS models this is as Boolean?, where null means .NoRequest
| enum class UserReuseRequest { | ||
| RequestReuse, | ||
| RequestNoReuse, | ||
| NoRequest |
There was a problem hiding this comment.
"User" can refer to either the merchant's users (i.e. customer) or Stripe's users (i.e. merchants). This should be renamed to "Customer" to avoid confusion.
nit: Rename to CustomerRequestedSave? "Reuse" implies the customer is trying to reuse the payment method, but they're only saving it at this point for reuse. They may never actually reuse it.
michelleb-stripe
dismissed stale reviews from skyler-stripe and yuki-stripe
via
e86e861
| is CharSequence -> { | ||
| if (value.isEmpty()) { | ||
| compactParams.remove(key) | ||
| } | ||
| } |
There was a problem hiding this comment.
I worry if this will break something
There was a problem hiding this comment.
I did look at annotations and didn't see a particular reason why this is true. I am curious at @yuki-stripe If you have this similar functionality on iOS where you globally remove all spaces and null parameters from all requests?
There was a problem hiding this comment.
We don't have the "if 'empty' parameter -> don't send" logic. Not sure about spaces.
There was a problem hiding this comment.
This is technically a breaking change but probably zero impact in practice. We can call it out in the CHANGELOG?
There was a problem hiding this comment.
yep, added to the changelog already.
Summary
There are three states that a New PaymentSelection can be in: RequestSave, RequestNoSave, or NoRequest.
Motivation
Reproduction steps:
Actual: Card is saved to the customer.
Expected: Card is not saved
Testing