Fix StripeIntent status check #4115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brnunes-stripe
requested review from
ccen-stripe,
michelleb-stripe and
mshafrir-stripe
as code owners
|
Diffuse output: |
ccen-stripe
previously requested changes
Aug 18, 2021
payments-core/src/main/java/com/stripe/android/paymentsheet/model/StripeIntentValidator.kt
Show resolved
Hide resolved
# Conflicts: # payments-core/src/main/java/com/stripe/android/paymentsheet/PaymentSheetViewModel.kt
michelleb-stripe
approved these changes
Aug 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Handle
StripeIntentstatus check only inStripeIntentValidator, log the error.Motivation
RUN_MOBILESDK-365
When
clientSecretcorresponds to aStripeIntentthat was already confirmed, the check inPaymentSheetViewModelwould result in getting stuck loading since the views were not ready to handle theViewStatechanges.Testing