Fix StripeEditText crash on instantiation #3905
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In `androidx.appcompat:appcompat:1.4.0-alpha02`, `addTextChangedListener()` is called by a `StripeEditText` superclass. This was causing a crash because `textWatchers` was not instantiated before it was accessed. Change `textWatchers` to nullable and initialize it in `StripeEditText`'s `init` block. Fixes #3770
mshafrir-stripe
requested review from
brnunes-stripe,
ccen-stripe and
michelleb-stripe
as code owners
|
Diffuse output: |
michelleb-stripe
previously approved these changes
Jun 30, 2021
michelleb-stripe
approved these changes
Jun 30, 2021
mshafrir-stripe
added a commit
that referenced
this pull request
Jul 2, 2021
In `androidx.appcompat:appcompat:1.4.0-alpha02`, `addTextChangedListener()` is called by a `StripeEditText` superclass. This was causing a crash because `textWatchers` was not instantiated before it was accessed. Change `textWatchers` to nullable and initialize it in `StripeEditText`'s `init` block. Fixes #3770
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
androidx.appcompat:appcompat:1.4.0-alpha02,addTextChangedListener()is called by aStripeEditTextsuperclass.This was causing a crash because
textWatcherswas not instantiatedbefore it was accessed. Change
textWatchersto nullable andinitialize it in
StripeEditText'sinitblock.Fixes #3770