Fix crash on Android 8 and 9 when opening the PaymentSheet #3721
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tting the enable/dislabed background color.
michelleb-stripe
requested review from
brnunes-stripe,
ccen-stripe and
mshafrir-stripe
as code owners
stripe/src/main/java/com/stripe/android/paymentsheet/BaseAddCardFragment.kt
Outdated
Show resolved
Hide resolved
brnunes-stripe
approved these changes
May 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
On Android 8 and 9 the background being set must be a drawable not a color or it will crash. In order to set the background color use background tint. I don't believe the background color is suppose to change when disabled in dark mode.
Motivation
stripe/stripe-react-native#212
Testing
Screenshots
Android 8
Android 9
Android 11
