Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move PaymentSheet example to /checkout endpoint. #3633

Merged
merged 7 commits into from
May 6, 2021
Merged

Conversation

brnunes-stripe
Copy link
Contributor

@brnunes-stripe brnunes-stripe commented Apr 23, 2021

Summary

Use /checkout endpoint for PaymentSheet example, as implemented in Glitch example.

Motivation

Simpler integration, use same endpoint as iOS.

Testing

  • Added tests
  • Modified tests
  • Manually verified

Copy link
Contributor Author

@brnunes-stripe brnunes-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will wait until example backend implements a /checkout endpoint like the Glitch example, so the example app uses a single backend.

@brnunes-stripe brnunes-stripe changed the title [WIP] Move PaymentSheet example to /checkout endpoint. Move PaymentSheet example to /checkout endpoint. Apr 26, 2021
@brnunes-stripe brnunes-stripe changed the title Move PaymentSheet example to /checkout endpoint. Move PaymentSheet example to /checkout endpoint. Apr 26, 2021
@michelleb-stripe
Copy link
Contributor

Let's just add a second property for the moment until we decide how/if we want to split the example app. This will allow us to close out this PR, start moving off of heroku, and take advantage of returning/new customers - woohoo!

@brnunes-stripe
Copy link
Contributor Author

Let's just add a second property for the moment until we decide how/if we want to split the example app. This will allow us to close out this PR, start moving off of heroku, and take advantage of returning/new customers - woohoo!

This is not great, but it's the simplest way if we want to merge this. We should refactor ASAP.
7b3608e

@brnunes-stripe
Copy link
Contributor Author

Merging this into mc branch then will work on top of it to move the PaymentSheet example into its own app.

@brnunes-stripe brnunes-stripe merged commit 1452cd4 into mc May 6, 2021
@brnunes-stripe brnunes-stripe deleted the brnunes/mc branch May 6, 2021 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants