Allow the user to set the default EditText color. #3457
Conversation
| @@ -89,12 +89,19 @@ open class StripeEditText @JvmOverloads constructor( | |||
| maxLines = 1 | |||
| listenForTextChanges() | |||
| listenForDeleteEmpty() | |||
| determineDefaultErrorColor() | |||
| cachedColorStateList = textColors | |||
There was a problem hiding this comment.
Isn't textColors == null before setTextColor() is called?
| override fun setTextColor(colors: ColorStateList?) { | ||
| super.setTextColor(colors) | ||
|
|
||
| // This will only use textColors and not colors because textColor is never null | ||
| cachedColorStateList = textColors | ||
| } |
There was a problem hiding this comment.
Can we add a new method setDefaultTextColor?
There was a problem hiding this comment.
We could but user's could still call setTextColor? What are the reservations on overriding this method?
Some things I like about this approach is that it works as expected they set the text color, and when there is an error we set it to the error color, and then will return it back to this when done. They don't have to know about the special stuff we are doing. Without changing the inherited parent, there is no way to prevent exposing this to our users.
It is just a function rename, so I can do it either way.
…nsistent with error processing.
| internal var defaultColorStateList: ColorStateList | ||
| @VisibleForTesting | ||
| internal set |
There was a problem hiding this comment.
you can remove internal set
Summary
This is a bit of a weird and tricky problem. The StripeEditText wants to set the color of the text based on if there is an error or not. In order to do this it called the setTextColor(Int) for errors and setTextColor(ColorStateList) for non-errors. In order to not replace the existing color it uses two member variables to track the color for error and non-error: errorColor and cachedColorStateList.
In the past the cacheColorState list was initialized by the constructor, and then never changed after that point. However if someone needs to update the color after initialization there was no way to do this. Calling setTextColor would end up just bring replaced as the field was set in error. When put back in a non-error state, it would set the color back to the value on initialization.
Motivation
This will help support customers wanting to set the text color
Testing