Allow stripe account to be configured on a per-request basis

[smaskell-stripe]

Summary

Adds a stripeAccountId parameter to most methods in Stripe.kt
Note: This does not update

• confirmPayment/onPaymentResult
• confirmSetupIntent/onSetupResult
• authenticateSource/onAuthenticateSourceResult

These will be updated later as they require passing the stripe account id through the intent

Motivation

ANDROID-247

Testing

Unit tests still pass

[smaskell-stripe]

@mshafrir-stripe any thoughts here? It looks like the account is added as an extra on the intent in some cases, but it doesn't seem consistent

[mshafrir-stripe]

You can skip adding it here. We should be passing it through the Intent.

[smaskell-stripe]

We should be but we aren't. Is that going to be a problem? If we don't add it here then doesn't that mean we have to also not add it in confirmPayment? Otherwise you could do something like this

val stripe = new Stripe(acct_1)
stripe.confirmPayment(this, params, acct_2)
...
stripe.onPaymentResult(requestCode, intent, callback) // uses acc_1 even though payment was for acct_2

Should we avoid adding support here (and other places that use onActivityResult) and follow up on that later?

[mshafrir-stripe]

you can set this to this.stripeAccountId

[mshafrir-stripe]

can we make stripeAccountId come after idempotencyKey in the args?

[smaskell-stripe]

👍 on args order. imo, since this is a private method, stripeAccountId should be required so that we don't accidentally forget to supply it somewhere. Let the compiler catch anywhere that might need to be updated, instead of just letting a bunch of places silently continue using the default when they shouldn't be. Don't feel too strongly about that though.

[smaskell-stripe]

oh I had it in this order because I feel like we typically put required params before optional ones (except for the callback which should be last)

[mshafrir-stripe]

that makes sense

[shengwei-stripe]

@mshafrir-stripe @smaskell-stripe
This just for discussion sake, do you think it is better or recommended to put idempotencyKey stripeAccount
Or is there any reason we could not re-use something like

stripe-android/stripe/src/main/java/com/stripe/android/ApiRequest.kt

Line 45 in d21b7fa

internal data class Options internal constructor(

[smaskell-stripe]

Either way seems fine to me. We're creating the request options in this function anyway but we could make them a parameter.

[mshafrir-stripe]

You can skip adding it here. We should be passing it through the Intent.

[anelder-stripe]

@aliriaz-stripe - Would you mind doing a quick pass on this to make sure it aligns with ANDROID-247?

[aliriaz-stripe]

LGTM