Fetch previously used PaymentMethod in PaymentSession #2179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary When a customer starts a new `PaymentSession`, if they have previously selected a payment method (determined via `PaymentSessionPrefs`), fetch the full `PaymentMethod` object from the API and update the `PaymentSessionData`. This behavior will only be triggered when `PaymentSessionConfig.shouldPrefetchCustomer == true`. Motivation Fixes #1977 Testing - Add unit tests - Manually verify
markfi-stripe
approved these changes
Feb 14, 2020
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When a customer starts a new
PaymentSession, if theyhave previously selected a payment method (determined
via
PaymentSessionPrefs), fetch the fullPaymentMethodobject from the API and update the
PaymentSessionData.This behavior will only be triggered when
PaymentSessionConfig.shouldPrefetchCustomer == true.Motivation
Fixes #1977
Testing
Customer selects a payment method, leaves the
PaymentSession, then starts a newPaymentSession. The UI is updated with the previously selected payment method.