Correctly validate country field on shipping address form #1845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mshafrir-stripe
force-pushed
the
country-validator
branch
from
4160456 to
2ed663c
Compare
- Validation was being incorrectly skipped in `PaymentFlowActivity`. Use `ShippingInfoWidget#shippingInformation` instead of `rawShippingInformation`. - Implement a `AutoCompleteTextView.Validator` in `CountryAutoCompleteTextView` and show an error message if the text is an invalid country. - When a user submits their shipping information in `PaymentFlowActivity`, perform validation using the `AutoCompleteTextView.Validator`. - Add string resource `address_country_invalid`. Create JIRA for translation. ANDROID-451
mshafrir-stripe
force-pushed
the
country-validator
branch
from
2ed663c to
1cca47b
Compare
chander-stripe
approved these changes
Nov 20, 2019
stripe/src/main/java/com/stripe/android/view/CountryAutoCompleteTextView.kt
Outdated
Show resolved
Hide resolved
stripe-ci
assigned mshafrir-stripe and unassigned felipecsl-stripe, chander-stripe and markfi-stripe
chander-stripe
approved these changes
Nov 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
PaymentFlowActivity. UseShippingInfoWidget#shippingInformationinsteadof
rawShippingInformation.AutoCompleteTextView.ValidatorinCountryAutoCompleteTextViewand show an errormessage if the text is an invalid country.
PaymentFlowActivity, perform validation usingthe
AutoCompleteTextView.Validator.address_country_invalid.Create JIRA for translation.
Motivation
ANDROID-451