don't select a payment method if the user it has selected nothing (#… #1792
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll fix the test with the next commit |
| @@ -5,6 +5,7 @@ import com.stripe.android.model.PaymentMethodFixtures | |||
| import kotlin.test.BeforeTest | |||
| import kotlin.test.Test | |||
| import kotlin.test.assertEquals | |||
| import kotlin.test.assertNull | |||
There was a problem hiding this comment.
this should come after import kotlin.test.assertNotNull
mshafrir-stripe
requested changes
Nov 6, 2019
Comment on lines
170
to
174
| val paymentMethodsAdapter = | ||
| recyclerView.adapter as PaymentMethodsAdapter | ||
|
|
||
| paymentMethodsAdapter.selectedPaymentMethodId = paymentMethod.id | ||
| assertEquals(paymentMethod.id, paymentMethodsAdapter.selectedPaymentMethod?.id) |
There was a problem hiding this comment.
you can delete these lines
There was a problem hiding this comment.
Hi Michael. If I delete the assignment the test fails because the selected payment method is null
|
@ISD4N thanks for fixing this! |
|
@mshafrir-stripe we need this patch to continue with the integration with Stripe. Do you need something else from me to be able to approve it? Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1676