Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable specifying Payment Method type to use in UI components #1738

Merged
merged 1 commit into from
Oct 22, 2019

Conversation

mshafrir-stripe
Copy link
Collaborator

Summary

  • Make PaymentSessionConfig#setPaymentMethodTypes() public
  • Make PaymentMethodsActivityStarter.Args.Builder#setPaymentMethodTypes() public
  • Make AddPaymentMethodActivityStarter.Args.Builder#setPaymentMethodType() public
  • Update and cleanup PaymentSessionActivity

Motivation

Allow users to specify other payment methods, such as PaymentMethod.Type.Fpx

Testing

Manually tested

- Make `PaymentSessionConfig#setPaymentMethodTypes()` public
- Make `PaymentMethodsActivityStarter.Args.Builder#setPaymentMethodTypes()` public
- Make `AddPaymentMethodActivityStarter.Args.Builder#setPaymentMethodType()` public
@mshafrir-stripe mshafrir-stripe merged commit 54ec498 into master Oct 22, 2019
@mshafrir-stripe mshafrir-stripe deleted the enable-payment-method-type branch October 22, 2019 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants