[BUG] PaymentSheetActivity.fetchConfig() race condition when activity recreates

[fbarthelery]

Summary

There is a race condition in PaymentSheetActivity.fetchConfig(). fetchConfig() is only called when the activity is created for the first time : link. The observation of viewModel.fetchFragmentConfig() triggers the transition to the next fragment : link.
It is possible for the activity to be recreated before getting a result from viewModel.fetchFragmentConfig(). In this case, transition to the next fragment doesn't happen and fetchConfig is not called during the onCreate() of the new fragment. This results in a PaymentSheet stuck in an infinite loading progress bar like #3744

Code to reproduce

As a race condition it may be hard to trigger. However, it happens consistently for me when calling PaymentSheet.presentWithPaymentIntent() from an activity in landscape. BaseSheetActivy requests a portrait orientation so PaymentSheetActivity is recreated.

Dependency Versions

stripe-android: 16.10.0

Gradle: 7.0

[mshafrir-stripe]

@fbarthelery thanks for the detailed issue report. We'll investigate this.

[brnunes-stripe]

Hi @fbarthelery, thanks for the details! Fixing this in #4034.