Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PaymentSheet not opening on Tablet in Landscape mode #245

Closed
emmaxCreative opened this issue Jul 28, 2021 · 7 comments
Closed

PaymentSheet not opening on Tablet in Landscape mode #245

emmaxCreative opened this issue Jul 28, 2021 · 7 comments
Labels
Android Issue related to Android native bindings blocked This issue is blocked by an external dependency issue bug Something isn't working

Comments

@emmaxCreative
Copy link

Describe the bug
When I use a tablet in landscape and want to open the payment screen then the screen automatically rotates to open the paymentSheet. Which fails and shows an infinite loading spinner.

Checkout Page (setting up the paymentSheet)
image

Next Step automatically rotates the screen but never opens the Sheet
image

No errors are thrown and the paymentSheet data is all set. But it does not open. Probably because of the forced rotation it loses a state somewhere.

BTW: When using the tablet in Portrait then the paymentSheet opens without problems

To Reproduce
Steps to reproduce the behavior:

  1. trigger paymentSheet in landscape mode on a tablet

Expected behavior
Open PaymentSheet in Landscape mode as well

Smartphone / tablet

  • Device: Pixel C Emulator
  • OS: Android 11
  • Package version: 1.2.0
  • Flutter version 2.2.2
@remonh87 remonh87 self-assigned this Jul 28, 2021
@remonh87
Copy link
Member

Thanks for reporting I can reproduce it (it happens also on phone on landscape). Funny thing is that I do not see any logs that result in a crash of some sort.

I think stripe/stripe-android#3878 may be related to it. @jonasbark You have a bit more knowledge about Android bindings, can you shine your light on this one?

@remonh87 remonh87 added Android Issue related to Android native bindings bug Something isn't working labels Jul 28, 2021
@jonasbark
Copy link
Member

Stripe Android SDK itself must force it to portrait only. When we find the time we will open a ticket at their repository for investigation.

@brnunes-stripe
Copy link

brnunes-stripe commented Aug 18, 2021

Hi @emmaxCreative, this was actually a bug on the Android SDK and has been fixed on v17.1.0, please try again once the dependency has been upgraded on the flutter project. We also plan on supporting landscape at some point in the future.

@remonh87 remonh87 removed their assignment Aug 22, 2021
@remonh87 remonh87 added the blocked This issue is blocked by an external dependency issue label Aug 22, 2021
@arcangeltech
Copy link

hello , i face the same problem with the paymentsheet (it opens only in portrait mode ) . Any solution please?

@remonh87
Copy link
Member

remonh87 commented Dec 6, 2021

@arcangeltech this should be actually fixed in the latest version of the library. Let me know if this is the case.

@brnunes-stripe
Copy link

Hi @arcangeltech,
To clarify, we fixed the bug that was raised in this ticket (stuck in loading). We did not implement support for landscape, so it will still switch to portrait. This is in our backlog, we just haven't been able to get to it yet.

@jamesblasco
Copy link
Member

I will close this issue as we are using a newer version that solves it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Android Issue related to Android native bindings blocked This issue is blocked by an external dependency issue bug Something isn't working
Projects
None yet
Development

No branches or pull requests

6 participants