Wrong behavior on select payment method.

[valentynsmetanin]

Summary

Wrong behavior on select payment method.
After calling presentPaymentMethodSelection(), if a user already has selected payment method and on click "back" on the activity AppBar or with the hardware button - onActivityResult receive Activity.RESULT_OK, but need to return Activity.RESULT_CANCELED.

Code to reproduce

private val paymentSession by lazy { PaymentSession(this) }

override fun onCreate(savedInstanceState: Bundle?) {
        super.onCreate(savedInstanceState)
        paymentSession.init(paymentSessionListener, PaymentSessionConfig.Builder().build(), savedInstanceState)
}

override fun onActivityResult(requestCode: Int, resultCode: Int, data: Intent?) {
        super.onActivityResult(requestCode, resultCode, data) // received resultCode = -1 (Activity.RESULT_OK)
        data?.let {
            paymentSession.handlePaymentData(requestCode, resultCode, it)
        }
}

Android version

6, 7, 8, 9, 10

Impacted devices

Google Pixel, Google Pixel 3

Installation method

Gradle

SDK version

12.3.0

Other information

On click "back" on the activity AppBar back on selecting a payment method must return resultCode = Activity.RESULT_CANCELED (0) in onActivityResult instead of Activity.RESULT_OK (-1)

[mshafrir-stripe]

@valentynsmetanin thanks for filing. Can you help me understand the underlying issue you're running into? Is it that the behavior changed from when you upgraded to the latest version, or that you simply expect a user tapping back to return Activity.RESULT_CANCELED?

I recommend not checking the result code yourself - let paymentSession.handlePaymentData() handle it.

[valentynsmetanin]

@mshafrir-stripe It's expected result in onActivityResult (Activity.RESULT_CANCELED) on back pressed. Also I have PaymentSession.PaymentSessionListener with own business logic. And I receive data in onPaymentSessionDataChanged on click "back" on the activity AppBar or with the hardware button too.