Relay error message on PaymentResult.Failed (#4512)

stripe · Jan 20, 2022 · 8bdd235 · 8bdd235
1 parent c56ff15
commit 8bdd235
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/...eet/src/main/java/com/stripe/android/paymentsheet/flowcontroller/DefaultFlowController.kt b/...eet/src/main/java/com/stripe/android/paymentsheet/flowcontroller/DefaultFlowController.kt
@@ -450,9 +450,7 @@ internal class DefaultFlowController @Inject internal constructor(
         }
         is PaymentResult.Failed -> {
             PaymentSheetResult.Failed(
-                IllegalArgumentException(
-                    "Failed to confirm intent: ${paymentResult.throwable.message}"
-                )
+                paymentResult.throwable
             )
         }
         else -> {

diff --git a/...src/test/java/com/stripe/android/paymentsheet/flowcontroller/DefaultFlowControllerTest.kt b/...src/test/java/com/stripe/android/paymentsheet/flowcontroller/DefaultFlowControllerTest.kt
@@ -697,13 +697,15 @@ internal class DefaultFlowControllerTest {
         }
 
     @Test
-    fun `onPaymentResult when error should invoke callback with Failed`() =
+    fun `onPaymentResult when error should invoke callback with Failed and relay error message`() =
         runTest {
-            flowController.onPaymentResult(PaymentResult.Failed(Throwable("error")))
+            val errorMessage = "Original error message"
+            flowController.onPaymentResult(PaymentResult.Failed(Throwable(errorMessage)))
 
             verify(paymentResultCallback).onPaymentSheetResult(
                 argWhere { paymentResult ->
-                    paymentResult is PaymentSheetResult.Failed
+                    paymentResult is PaymentSheetResult.Failed &&
+                        errorMessage == paymentResult.error.localizedMessage
                 }
             )
         }