Remove tablet check and remove force portrait

stripe · Apr 12, 2022 · 70d3296 · 70d3296
1 parent 169e788
commit 70d3296
Show file tree

Hide file tree

Showing 4 changed files with 1 addition and 17 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -3,7 +3,7 @@
 
 ### PaymentSheet
 * [FIXED] [4861](https://github.com/stripe/stripe-android/pull/4861) Remove font resource to save space and default to system default
-* [CHANGED] [4855](https://github.com/stripe/stripe-android/pull/4855) Remove force portrait mode for tablets.
+* [CHANGED] [4855](https://github.com/stripe/stripe-android/pull/4855) Remove force portrait mode in PaymentLauncher.
 
 ## 20.0.1 - 2022-04-11
 This release includes several PaymentSheet bug fixes.

diff --git a/payments-core/res/values-sw600dp/attrs.xml b/payments-core/res/values-sw600dp/attrs.xml
diff --git a/payments-core/res/values/attrs.xml b/payments-core/res/values/attrs.xml
@@ -29,6 +29,4 @@
         </attr>
         <attr name="backgroundColorStateList" format="reference" />
     </declare-styleable>
-
-    <bool name="isTablet">false</bool>
 </resources>
diff --git a/...n/java/com/stripe/android/payments/paymentlauncher/PaymentLauncherConfirmationActivity.kt b/...n/java/com/stripe/android/payments/paymentlauncher/PaymentLauncherConfirmationActivity.kt
@@ -3,14 +3,11 @@ package com.stripe.android.payments.paymentlauncher
 import android.annotation.SuppressLint
 import android.app.Activity
 import android.content.Intent
-import android.content.pm.ActivityInfo
-import android.os.Build
 import android.os.Bundle
 import androidx.activity.viewModels
 import androidx.annotation.VisibleForTesting
 import androidx.appcompat.app.AppCompatActivity
 import androidx.lifecycle.ViewModelProvider
-import com.stripe.android.R
 import com.stripe.android.view.AuthActivityStarterHost
 
 /**
@@ -37,13 +34,6 @@ internal class PaymentLauncherConfirmationActivity : AppCompatActivity() {
     @SuppressLint("SourceLockedOrientationActivity")
     override fun onCreate(savedInstanceState: Bundle?) {
         super.onCreate(savedInstanceState)
-        if (Build.VERSION.SDK_INT != Build.VERSION_CODES.O &&
-            !resources.getBoolean(R.bool.isTablet)
-        ) {
-            // In Oreo, Activities where `android:windowIsTranslucent=true` can't request
-            // orientation. See https://stackoverflow.com/a/50832408/11103900
-            requestedOrientation = ActivityInfo.SCREEN_ORIENTATION_PORTRAIT
-        }
 
         disableAnimations()