Skip to content

Commit

Permalink
Update Proguard rules (#1238)
Browse files Browse the repository at this point in the history
- Add BouncyCastle to `:stripe` Proguard rules
- Enable `minifyEnabled` for samplestore + example apps
  to help expose integration issues
- Add Stripe SDK Proguard rules to apps
  • Loading branch information
mshafrir-stripe authored Jul 23, 2019
1 parent 6d7d836 commit 5ff318f
Show file tree
Hide file tree
Showing 5 changed files with 10 additions and 2 deletions.
2 changes: 1 addition & 1 deletion example/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ android {

buildTypes {
debug {
minifyEnabled false
minifyEnabled true
proguardFiles getDefaultProguardFile('proguard-android.txt'), 'proguard-rules.pro'
}
release {
Expand Down
3 changes: 3 additions & 0 deletions example/proguard-rules.pro
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,9 @@
-keepattributes Exceptions


# Stripe SDK rules
-keep class com.stripe.android.** { *; }


# OkHttp rules

Expand Down
2 changes: 1 addition & 1 deletion samplestore/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ android {

buildTypes {
debug {
minifyEnabled false
minifyEnabled true
proguardFiles getDefaultProguardFile('proguard-android.txt'), 'proguard-rules.pro'
}
release {
Expand Down
3 changes: 3 additions & 0 deletions samplestore/proguard-rules.pro
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,9 @@
-keepattributes Exceptions


# Stripe SDK rules
-keep class com.stripe.android.** { *; }


# OkHttp rules

Expand Down
2 changes: 2 additions & 0 deletions stripe/proguard-rules.txt
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
-keep class android.support.design.widget.TextInputLayout { *; }
-keep class android.support.design.widget.CollapsingTextHelper { *; }
-keep class org.bouncycastle.** { *; }

-dontwarn com.stripe.android.view.**

0 comments on commit 5ff318f

Please sign in to comment.