Fix ES Module interop #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Restore ES Module interop (partial rollback of #31)
christopher-stripe
approved these changes
Feb 10, 2020
package.json
Outdated
| @@ -14,9 +14,10 @@ | |||
| "lint:prettier": "prettier './**/*.js' './**/*.css' './**/*.md' --list-different", | |||
| "typecheck": "tsc", | |||
| "build": "yarn run clean && yarn run rollup -c", | |||
| "checkimport": "grep 'import [^*{]' dist/react-stripe.d.ts; case $? in 1) true ;; 0) echo Found invalid import; false ;; *) false ;; esac", | |||
There was a problem hiding this comment.
(2) Neat. Would be nice to read this in a separate file in a scripts directory, with a comment on how to fix this issue
|
Thanks guys! Can you republish the NPM module? |
|
Published as v1.0.0-beta.6! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & motivation
Fix #33
#31 used names exports for package "prop-types", which doesn't work when using this package as an ES Module.
Partially reverts #31 to use default imports for packages that expect them, but make sure generated types don't use default import to preserve the intent of #31.
Testing & documentation
Verified in a test project the exported types are complete.
Added a test on generated type definitions to ensure we don't re-introduce default import for types in the future.
Note
Check v1.0.0-beta.4...hofman/fix-esmodule-interop to see the combined change with #31