Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix isEqual to work with special object. #235

Merged
merged 2 commits into from
Nov 4, 2021
Merged

Conversation

rado-stripe
Copy link
Contributor

Summary & motivation

Fixes #230.

API review

Copy this template or link to an API review issue.

Testing & documentation

Added test.

Copy link
Contributor

@tylersmith-stripe tylersmith-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks reasonable to me!

@rado-stripe
Copy link
Contributor Author

I was waiting on #230 user to add more repro info, but might as well merge this (as it fixes at least one case), while waiting on more info.

@tylersmith-stripe tylersmith-stripe merged commit 9e7f31a into master Nov 4, 2021
@tylersmith-stripe tylersmith-stripe deleted the rado-fix-230 branch November 4, 2021 05:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

isEqual flawed
3 participants