Skip to content
This repository has been archived by the owner on Apr 8, 2021. It is now read-only.

Make brushfire buildable in both 2.10 and 2.11 #34

Merged
merged 1 commit into from
Feb 13, 2015
Merged

Conversation

colinmarc
Copy link
Contributor

@avibryant
Copy link
Contributor

So how does one do a 2.10 build with this?

@colinmarc
Copy link
Contributor Author

You have to specify scala.version and scala.binary.version. So for example:

mvn -Dscala.version=2.10.4 -Dscala.binary.version=2.10 clean package

@colinmarc
Copy link
Contributor Author

This builds (and deploys) brushfire-core and brushfire-scalding just fine, but not brushfire-finatra, because there's no finatra for 2.11: twitter/finatra#185

@avibryant
Copy link
Contributor

Ok so let's have it default to 2.10 then so it all builds, then we can have a somewhat more manual process to get the 2.11 artifacts?

@colinmarc
Copy link
Contributor Author

Makes sense. The build works now.

colinmarc added a commit that referenced this pull request Feb 13, 2015
Make brushfire buildable in both 2.10 and 2.11
@colinmarc colinmarc merged commit d922fbe into master Feb 13, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants