Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alternative method of running rake work_jobs #419

Closed
wants to merge 5 commits into from
Closed

Alternative method of running rake work_jobs #419

wants to merge 5 commits into from

Conversation

zlogic
Copy link

@zlogic zlogic commented Feb 27, 2016

A fix for the forked bundle exec rake work_jobs process crashing on Heroku (issue #411).
This includes a basic worker (just run bundle exec rake work_jobs and restart on failure) and a "full worker" which does most of the daily tasks without a scheduler. It's possible to choose which ones to use in the dashboard and having up to 1 worker is free of charge.

worker

@swanson
Copy link
Collaborator

swanson commented Feb 27, 2016

Thanks - I need to look into this more in-depth. I missed this blog post: https://blog.heroku.com/archives/2015/5/7/heroku-free-dynos that introduces the free worker dyno, which sounds awesome.

@Koronen
Copy link
Contributor

Koronen commented May 3, 2016

I like the gist of this fix. Thank you! 👍

Here are some of my thoughts:

  • Do we need two process definitions?

    The docs currently instruct users to configure cron jobs (Heroku Scheduler or similar) for scheduling fetching of new stories, and for cleaning out old stories. Maybe it's sufficient to keep just the delayed_worker process definition?

  • Do we need the loop?

    I think at least Heroku restarts crashed processes automatically.

    Dynos are also restarted if the processes running in the dyno exit.

    https://devcenter.heroku.com/articles/dynos#restarting

  • How can we provide a smooth upgrade process for everyone using this app?

    There's probably some documentation that could be updated to reflect this change in behavior.

@gabrielpoca
Copy link
Contributor

Closing this PR for lack of activity.

@gabrielpoca gabrielpoca closed this Apr 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants