-
-
Notifications
You must be signed in to change notification settings - Fork 400
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build Docker image and push to Dockerhub #1080
Conversation
@mockdeep hopefully it works this time! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much for this! I think this will help a lot with environment issues.
.github/workflows/build.yaml
Outdated
username: ${{ secrets.DOCKERHUB_USERNAME }} | ||
password: ${{ secrets.DOCKERHUB_TOKEN }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've set these secrets, so hopefully that'll work.
3a982e0
to
533c95d
Compare
tags: | | ||
${{ steps.get-tag-latest.outputs.tags }} | ||
${{ steps.get-tag-sha.outputs.tags }} | ||
cache-from: type=gha |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe that this cache-from
will cache to/from the Github Actions environment, so there's no need to pull an image locally, but I'm not 100% confident.
Updated the PR with your suggestions and rebased them into the second commit. Should I keep the |
Let's give it a try! I'm wondering why we don't see the image building on this PR, but maybe we need to merge it before it will run.
I think |
It worked?!! |
Oh, I didn't even think to look. It did! |
* revert CircleCI build changes * add build and push to dockerhub via github actions
As mentioned in #1051, the CircleCI docker build step isn't working, and we want to move it to a Github Action instead. This PR has two commits:
This will require two secrets that I believe can be set in the repository settings somewhere: one for a
DOCKERHUB_USERNAME
and another for aDOCKERHUB_TOKEN
. I also went ahead and added both an amd64 and an arm64 build here, and am hoping that it just works (tm).I also once again set the build and push to only happen when
main
is pushed to / gets new commits, but I think we can change that to work only on this branch from my fork if we want to test before merging.