Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

StrimziKafkaCluster KRaft mode #89

Merged
merged 4 commits into from
Oct 16, 2024
Merged

StrimziKafkaCluster KRaft mode #89

merged 4 commits into from
Oct 16, 2024

Conversation

see-quick
Copy link
Member

This PR adds support for KRaft within StrimziKafkaCluster. Currently, we are able to run in KRaft mode with the single-node instance.

@see-quick see-quick added this to the 0.108.0 milestone Oct 16, 2024
@see-quick see-quick self-assigned this Oct 16, 2024
scholzj
scholzj reviewed Oct 16, 2024
View reviewed changes
.checkstyle/checkstyle.xml Outdated Show resolved Hide resolved
@see-quick
code sweep a little bit
6f9d196 
Signed-off-by: see-quick <[email protected]>
@see-quick see-quick marked this pull request as ready for review October 16, 2024 08:13
@see-quick see-quick added the enhancement New feature or request label Oct 16, 2024
@see-quick see-quick linked an issue Oct 16, 2024 that may be closed by this pull request
StrimziKafkaCluster shoud allow running in KRaft mode #82
Closed
@see-quick see-quick requested a review from a team October 16, 2024 08:14
scholzj
scholzj approved these changes Oct 16, 2024
View reviewed changes
Copy link
Member

@scholzj scholzj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM assuming it works 😉. At some poinbt we should also update the README. But that can be done in separate PR. Thanks.

@see-quick
fix single-node
800116c 
Signed-off-by: see-quick <[email protected]>
@see-quick
Copy link
Member Author

see-quick commented Oct 16, 2024 •
edited
Loading

LGTM assuming it works 😉. At some poinbt we should also update the README. But that can be done in separate PR. Thanks.

Yeah, I will update README in a separate PR.

@see-quick see-quick merged commit 408a2a2 into main Oct 16, 2024
7 checks passed
@see-quick see-quick deleted the prepare-kraft-cluster branch October 17, 2024 15:06
@fedinskiy fedinskiy mentioned this pull request Dec 20, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scholzj scholzj scholzj approved these changes

@jankalinic jankalinic jankalinic approved these changes

Assignees

@see-quick see-quick

Labels
enhancement New feature or request
Projects
None yet
Milestone
0.108.0
Development

Successfully merging this pull request may close these issues.

StrimziKafkaCluster shoud allow running in KRaft mode
3 participants
@see-quick @scholzj @jankalinic