Various Java cleanups #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mimaison
commented
Nov 14, 2024
•
mimaison
commented
- Removed usage of deprecated APIs
- Minor refactorings and code simplifications
Signed-off-by: Mickael Maison <[email protected]>
mimaison
commented
Nov 14, 2024
| @@ -197,7 +197,7 @@ public String toString() { | |||
| */ | |||
| public KafkaVersion latestRelease() { | |||
| // at least one release in the json schema is needed | |||
| if (this.logicalKafkaVersionEntities == null || this.logicalKafkaVersionEntities.size() < 1) { | |||
| if (this.logicalKafkaVersionEntities.isEmpty()) { | |||
There was a problem hiding this comment.
The field is final and initialized when declared so it should never be null.
mimaison
commented
Nov 14, 2024
| * @param ready lambda predicate | ||
| */ | ||
| static long waitFor(String description, long pollIntervalMs, long timeoutMs, BooleanSupplier ready) { | ||
| static long waitFor(String description, Duration pollInterval, Duration timeout, BooleanSupplier ready) { |
There was a problem hiding this comment.
The class is not public so I assume it's only used by this project and we can change its declaration.
mimaison
commented
Nov 14, 2024
| @@ -72,7 +72,7 @@ void testStartContainerWithEmptyConfiguration(final String imageName) { | |||
| systemUnderTest.start(); | |||
|
|
|||
| assertThat(systemUnderTest.getBootstrapServers(), is("PLAINTEXT://" | |||
| + systemUnderTest.getContainerIpAddress() + ":" + systemUnderTest.getMappedPort(9092))); | |||
| + systemUnderTest.getHost() + ":" + systemUnderTest.getMappedPort(9092))); | |||
There was a problem hiding this comment.
getContainerIpAddress() is deprecated, so switching to getHost() which is the preferred method now.
mimaison
commented
Nov 14, 2024
| @@ -18,8 +18,8 @@ | |||
| import static org.hamcrest.CoreMatchers.containsString; | |||
| import static org.hamcrest.CoreMatchers.is; | |||
| import static org.hamcrest.MatcherAssert.assertThat; | |||
| import static org.junit.Assert.assertTrue; | |||
There was a problem hiding this comment.
This is the junit 4 dependency brought via testcontainers. We should instead use org.junit.jupiter.api.Assertions which is junit 5 (the declared dependency in pom.xml).
see-quick
approved these changes
Nov 15, 2024
|
Thanks, I updated the description. |
im-konge
approved these changes
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.