Add Controller listener to the advertised.listeners

[see-quick]

This PR adds the CONTROLLER to advertised.listeners.

[scholzj]

I think you need to be careful with this. You want to listen on 0.0.0.0. But you do not want to advertise it. That does not seem to be what you are doing here.

[see-quick]

I think you need to be careful with this. You want to listen on 0.0.0.0. But you do not want to advertise it. That does not seem to be what you are doing here.

I see, currently, we have in single-node this configuration

advertised.listeners=PLAINTEXT\://localhost\:33219,BROKER1\://10.90.209.2\:9091
broker.id=1
controller.listener.names=CONTROLLER
controller.quorum.voters=1@broker-1\:9094
inter.broker.listener.name=BROKER1
listener.security.protocol.map=PLAINTEXT\:PLAINTEXT,CONTROLLER\:PLAINTEXT,BROKER1\:PLAINTEXT
listeners=PLAINTEXT\://0.0.0.0\:9092,BROKER1\://0.0.0.0\:9091,CONTROLLER\://broker-1\:9094
...

for the controller listener, I had to change it to DNS [1] i.e., CONTROLLER\://broker-1\:9094. But I assume instead of BROKER1\://10.90.209.2\:9091 I can use BROKER1\://broker-1\:9091. That way for instance producer or consumer would easily connect to the internal docker network by just specifying BROKER1\://broker-1\:9091 as bootstrap servers. External clients have to use PLAINTEXT\://localhost\:33219.

[1] - apache/kafka@9be27e7

[scholzj]

No. You need to add the controller to the advertised hosts.

[scholzj]

This is pretty unreliable. I think we need to have better way to configure KAfka version than through the container image. If you do not want to solve it in this PR it might be fine, but we should have issues to track this.

This is pretty likel to fail when using custom images when in various ofline / disconnected environments, when you want to fix to use some specific image through digest etc.

[see-quick]

Yeah, I was thinking about the same with custom images. I can create an issue when I solve that also for custom images or at least log a warning when using custom images.

[scholzj]

I think it should work like this:

• The builders should have a withVersion field/method
• If not set, the default version (the latest Kafka version) should be used
• The image should be by the users always set to correspond to the version

I think that is the way it should work. (As I said, I'm happy to leave it for later and not block this PR.)

[see-quick]

Yeah, I think I have come up with a more clear solution. Let me know what you think

[see-quick]

Okay, that doesn't seem to work :/. I will have to think about that.....created issue [1] to track it. And I rollback that solution I had previously.

[1] - #112