Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update of unit tests to use KRaft - part 10 #10477

Merged
merged 1 commit into from
Aug 21, 2024

Conversation

scholzj
Copy link
Member

@scholzj scholzj commented Aug 20, 2024

Type of change

  • Task

Description

This is another part of the unit test refactoring to better support KRaft. It continues in refactoring the unit tests for the model classes.

  • Several tests were just updated to use KRaft as they did not directly depend on ZooKeeper:
    • KafkaExporterTest
    • KafkaClusterOAuthValidationTest
    • KafkaPoolTest
    • ModelUtilsTest
  • For several other classes, the tests where split into different classes to separate the ZooKeeper a KRaft based tests. I also made sure the KRaft-based tests provided the same coverage as the ZooKeeper-based tests. This includes:
    • KRaftUtilsTest and KRaftUtilsZooBasedTest
    • KafkaSpecCheckerTest, KafkaSpecCheckerZooBasedTest, and KafkaSpecCheckerZooBasedWithNodePoolsTest
    • NodePoolUtilsTest and NodePoolUtilsZooBasedTest

Checklist

  • Write tests
  • Make sure all tests pass

@scholzj scholzj added this to the 0.44.0 milestone Aug 20, 2024
@scholzj scholzj requested a review from a team August 20, 2024 22:04
@scholzj scholzj merged commit 9282459 into strimzi:main Aug 21, 2024
13 checks passed
@scholzj scholzj deleted the wave-10-of-KRaft-unit-test-updates branch August 21, 2024 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants