Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ST] Deflake Connector ST weird usernames TLS/SCRAM tests #10382

Merged
merged 1 commit into from
Jul 25, 2024

Conversation

henryZrncik
Copy link
Contributor

@henryZrncik henryZrncik commented Jul 24, 2024

Type of change

  • Bugfix

Description

testConnectScramShaAuthWithWeirdUserName and testConnectTlsAuthWithWeirdUserName in ConectST were using external clients and creating new TestStorage (which was not referencing the same data as the TestStorage instance from test) in helper function testConnectAuthorizationWithWeirdUserName .

  • External clients were replaced with internals as the only reason for them was that the internal clients were not available that time
  • helper method was replaced with 3 additional steps in each of those method.

Fixes #7608

@henryZrncik henryZrncik self-assigned this Jul 24, 2024
@henryZrncik henryZrncik added this to the 0.43.0 milestone Jul 24, 2024
@Frawless
Copy link
Member

/azp run regression

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@henryZrncik
Copy link
Contributor Author

Azure is okay the fail is unrelated (the problem is currently flaky KafkaRebalance test which is part of another topic/PR).

@henryZrncik henryZrncik added ready for merge Label for PRs which are ready for merge and removed needs review labels Jul 25, 2024
@im-konge im-konge merged commit b834aea into strimzi:main Jul 25, 2024
19 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for merge Label for PRs which are ready for merge System tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove un-necessary NodePorts from system test.
3 participants