-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(tuning): consumer config: updates content on rebalances #10292
docs(tuning): consumer config: updates content on rebalances #10292
Conversation
Signed-off-by: prmellor <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR. I left a few comments and suggestions.
documentation/modules/managing/con-consumer-config-properties.adoc
Outdated
Show resolved
Hide resolved
documentation/modules/managing/con-consumer-config-properties.adoc
Outdated
Show resolved
Hide resolved
documentation/modules/managing/con-consumer-config-properties.adoc
Outdated
Show resolved
Hide resolved
documentation/modules/managing/con-consumer-config-properties.adoc
Outdated
Show resolved
Hide resolved
documentation/modules/managing/con-consumer-config-properties.adoc
Outdated
Show resolved
Hide resolved
Signed-off-by: prmellor <[email protected]>
Thanks for comments @mimaison |
documentation/modules/managing/con-consumer-config-properties.adoc
Outdated
Show resolved
Hide resolved
documentation/modules/managing/con-consumer-config-properties.adoc
Outdated
Show resolved
Hide resolved
…d session timeout): Signed-off-by: prmellor <[email protected]>
Thanks for feedback @showuon |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the updates. LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…#10292) Signed-off-by: prmellor <[email protected]>
Documentation
Expands the consumer configuration content to say more on handling scaling in order to minimize the impact of rebalances
Checklist
Please go through this checklist and make sure all applicable tasks have been done