Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(tuning): consumer config: updates content on rebalances #10292

Merged
merged 3 commits into from
Jul 4, 2024

Conversation

PaulRMellor
Copy link
Contributor

@PaulRMellor PaulRMellor commented Jul 2, 2024

Documentation

Expands the consumer configuration content to say more on handling scaling in order to minimize the impact of rebalances

Checklist

Please go through this checklist and make sure all applicable tasks have been done

  • Write tests
  • Make sure all tests pass
  • Update documentation
  • Check RBAC rights for Kubernetes / OpenShift roles
  • Try your changes from Pod inside your Kubernetes and OpenShift cluster, not just locally
  • Reference relevant issue(s) and close them after merging
  • Update CHANGELOG.md
  • Supply screenshots for visual changes, such as Grafana dashboards

@PaulRMellor PaulRMellor added this to the 0.42.0 milestone Jul 2, 2024
@PaulRMellor PaulRMellor requested review from mimaison and showuon July 2, 2024 08:20
@PaulRMellor PaulRMellor self-assigned this Jul 2, 2024
Copy link
Contributor

@mimaison mimaison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. I left a few comments and suggestions.

@scholzj scholzj modified the milestones: 0.42.0, 0.43.0 Jul 2, 2024
@PaulRMellor
Copy link
Contributor Author

Thanks for comments @mimaison
I've addressed them all.

@PaulRMellor
Copy link
Contributor Author

Thanks for feedback @showuon
I've addressed the comment

Copy link
Contributor

@mimaison mimaison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates. LGTM

Copy link
Member

@showuon showuon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@tinaselenge tinaselenge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@scholzj scholzj merged commit b6c9fc3 into strimzi:main Jul 4, 2024
13 checks passed
mstruk pushed a commit to mstruk/strimzi-kafka-operator that referenced this pull request Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants