[system test] - fix testJbodMetadataLogRelocation for >= 3.7.0 Kafka … #10093
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…version Signed-off-by: see-quick <[email protected]>
Signed-off-by: see-quick <[email protected]>
im-konge
approved these changes
May 9, 2024
scholzj
reviewed
May 9, 2024
There was a problem hiding this comment.
should we have the same comment / TODO as for the other tests?
// JBOD storage in KRaft is supported only from Kafka 3.7.0 and higher.
// So we want to run this test when KRaft is disabled or when it is with KRaft and Kafka 3.7.0+
// TODO: remove once support for 3.6.x is removed - https://github.com/strimzi/strimzi-kafka-operator/issues/9921
agree :) will do |
Signed-off-by: see-quick <[email protected]>
scholzj
approved these changes
May 9, 2024
see-quick
added
ready for merge
scholzj
pushed a commit
that referenced
this pull request
May 10, 2024
#10093) Signed-off-by: see-quick <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…version
Type of change
Description
This PR fixes a problem when we run a release pipeline with the 3.6.2 version this test case failed because it is not intended to run on 3.6.2 because multiple JBOD volumes are not supported (expected). Thus I have updated the assumption condition here.
Should be cherry-picked to
release-0.41.x:) if possibleChecklist