Assignment test + NPE fix #490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
im-konge
approved these changes
Nov 9, 2020
ppatierno
reviewed
Nov 13, 2020
| @@ -357,6 +357,7 @@ private void partitionsAssignmentAndSeek() { | |||
| Optional<PartitionInfo> requestedPartitionInfo = | |||
| availablePartitions.stream() | |||
| .filter(p -> p.getTopic().equals(topicSubscription.getTopic()) && | |||
| topicSubscription.getPartition() != null && | |||
There was a problem hiding this comment.
can you explain in which case this can be null?
There was a problem hiding this comment.
If we do subscribe to a topic, it is stored into topicSubscriptions. Subscription request body might be for example
{
"topics": [
"topic1",
"topic2"
]
}
If we do assign after subscription (what is wrong because of exclusivity), we iterate through all topic subscriptions in topicSubscriptions and we are trying to get partitions. And because the subscription body does not have any partitions info, it is null. Then just comparing null causes NPE.
src/main/java/io/strimzi/kafka/bridge/http/HttpSinkBridgeEndpoint.java
Outdated
Show resolved
Hide resolved
src/test/java/io/strimzi/kafka/bridge/http/ConsumerSubscriptionTest.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Stanislav Knot <[email protected]>
Signed-off-by: Stanislav Knot <[email protected]>
Signed-off-by: Stanislav Knot <[email protected]>
Signed-off-by: Stanislav Knot <[email protected]>
Signed-off-by: Stanislav Knot <[email protected]>
sknot-rh
force-pushed
the
assignment-fixes
branch
from
fb56fc8 to
d0219bc
Compare
ppatierno
approved these changes
May 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Stanislav Knot [email protected]
Assigment endpoint does not have any tests.
Trying to access
subscribeandassignendpoints ends up with NPE. After fix of NPE, it does not return 409 (Conflict).Fixes #489