Update Fabric8 kubernetes client to 7.0.1 #69
Conversation
Including replacing the deprecated crd-generator-apt with its replacement crd-generator-api-v2 (See https://github.com/fabric8io/kubernetes-client/blob/main/doc/CRD-generator-migration-v2.md) Signed-off-by: MichaelMorris <[email protected]>
| <scope>provided</scope> | ||
| </dependency> | ||
| <dependency> | ||
| <groupId>io.sundr</groupId> |
There was a problem hiding this comment.
Why do we need this dependency? From the fabric8 release notes it seemed like the old api was based on Sundrio, but not the new one
There was a problem hiding this comment.
We are using sundrio annotations in the kafka-access code (to create builder classes e.g. for KafkaAccess).
We didn't need to add the dependency previously as it was coming in from crd-generator-apt, however as the new crd-generator-api-v2 does not include it, we must now add it to continue using those annotations in the kafka-access code
There was a problem hiding this comment.
I wonder if we can get rid of the quotes in some way? Doesn't Fabric8 have some option for it?
There was a problem hiding this comment.
Fabric8 7 switched the default HTTP client. So I think you need to update the exclude for the OkHttp client to VErt.x client?
Update Fabric8 kubernetes client to 7.0.1
Including replacing the deprecated crd-generator-apt with its replacement crd-generator-api-v2 (See https://github.com/fabric8io/kubernetes-client/blob/main/doc/CRD-generator-migration-v2.md)
This should enable the completion of the remaining items of #53 (comment)