Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "Add Asset Pop-Up" height #2517

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

minktusk
Copy link
Contributor

PR Details

The "Add Asset Pop-Up" does not have a height limit

Before:

gOl1S5DjA4

After:

qXfpZkc6EN

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My change requires a change to the documentation.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have built and run the editor to try this change out.

@Doprez
Copy link
Contributor

Doprez commented Nov 13, 2024

Will these changes be consistent across different resolutions? It seems like this change only has an effect since the height was hard coded before to account for the list size so the scroll bar would have been available if any items were added in the future.

If it is not consistent across different resolutions or scales then I think we should consider that as a fix instead.

@minktusk minktusk changed the title Resize "Add Asset Pop-Up" Fix "Add Asset Pop-Up" height Nov 13, 2024
@minktusk
Copy link
Contributor Author

Sorry for not being more specific earlier!

Yes, this is a fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants