Add a WithinTimes assertion #689
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I've been testing some code that generates timestamps and found that I'm often thinking in terms 'time should be between a and b'. So I think this might be helpful. Example of how I've been writing my tests: ```go before := time.Now() data := DoSomething() after := time.Now() assert.WithinTimes(t, before, data.timestamp, after) ``` Without this, I have to use `WithinDuration`, which I find _slightly_ cumbersome to setup and read. ```go before := time.Now() data := DoSomething() span := time.Since(before) /2 midpoint := before.Add(span) assert.WithinDuration(t, midpoint, data.timestamp, span) ```
goodspark
force-pushed
the
goodspark/add-within-times-assertion
branch
from
75d09c7 to
688c4ca
Compare
|
I have no idea how to get |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been testing some code that generates timestamps and found that I'm often thinking in terms of 'time should be between a and b'. So I think this might be helpful.
Example of how I'd like to write my tests:
Without this, I have to use
WithinDuration, which I find slightly cumbersome to setup and read.