README: replace Testify V2 notice with @dolmen's V2 manifesto #1518

hendrywiranto · 2023-12-10T07:40:35Z

Summary

Remove Testify V2 notice on README.md since it won't happen

Changes

Remove Testify V2 notice on README.md

Motivation

According to this announcement #1089 (comment) from @dolmen

So, as the current only active maintainer, I'm declaring that v2 will never happen. Or at least a v2 of the github.com/stretchr/testify module with such major breaking changes.

Related issues

Issues that can be closed:
#1089

Antonboom · 2023-12-10T09:29:24Z

hi!

maybe it's better not to remove, but (in contradict) notice about v2 manifesto?

hendrywiranto · 2023-12-10T18:24:06Z

hi!

maybe it's better not to remove, but (in contradict) notice about v2 manifesto?

Yes, I think that's also a good idea. I'm thinking if maintainers want to link the manifesto instead I will just change the MR

Lets wait his response maybe?

dolmen · 2024-01-05T13:44:13Z

Yes, linking to my manifesto would be better.
In a normal world I would have made the change in the README myself, but as I am not allowed to merge my own PRs, I'm relying on other contributors to submit such patches. 😓

hendrywiranto · 2024-01-06T17:14:46Z

Thanks for the answer, I have updated the readme with the manifesto
Please tell me if you think there is a better wording for this

Antonboom · 2024-01-09T07:13:54Z

@hendrywiranto also grep "testify v2"
e.g. https://github.com/stretchr/testify/blob/master/doc.go

hendrywiranto · 2024-01-10T16:06:17Z

thanks for the reminder @Antonboom

MovieStoreGuy · 2024-01-17T16:34:59Z

Hi,

I am relatively new comer to the maintainers group for this, I mostly come from the opentelemetry collector contrib where I use this heavily, and also internally here at Altassian.

As slow as it has been for V2 (apologies for those asking for it), I think it should be the ambition of 2024 to see v2 released.

Let me follow up with @boyan-soubachov on this and we can start getting together a more formal roadmap / milestone for V2 if it doesn't already exist.

hendrywiranto · 2024-01-17T17:27:18Z

Hi @MovieStoreGuy

I'm glad to hear that there is still plan for V2!
Hope you guys can figure something out while making sure this repo (V1) is still maintained regularly

Thanks!

brackendawson

I don't think there is a concensus about this between the maintainers right now. I'm not requesting any changes, just temporarily putting a hold on this.

dolmen · 2024-03-05T14:04:05Z

I have proposed a different wording to expose the active debate about v2.

brackendawson

I at least have changed my mind about testtify v2, that may mean there is now a concensus among the maintainers that it is a no.

brackendawson · 2024-09-29T22:13:17Z

README.md

+Notice about Testify V2:
+It won't happen due to various reasons. You can read more about it on the maintainer's manifesto [here](https://github.com/stretchr/testify/issues/1089#issuecomment-1812734472).


Suggested change

Notice about Testify V2:

It won't happen due to various reasons. You can read more about it on the maintainer's manifesto [here](https://github.com/stretchr/testify/issues/1089#issuecomment-1812734472).

> [!NOTE]

> Testify is being maintained at v1, no breaking changes will be accepted in this repo. [See discussion about v2](https://github.com/stretchr/testify/discussions/1560).

Suggest using a proper GitHub markdown note and remove the emotional language from the note.

Hi @brackendawson
Thank you for finally coming to a concensus, I have applied your suggestion. 😄

…nercloud/fleeting-plugin-hetzner!175) This MR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [github.com/stretchr/testify](https://github.com/stretchr/testify) | require | minor | `v1.9.0` -> `v1.10.0` | --- ### Release Notes <details> <summary>stretchr/testify (github.com/stretchr/testify)</summary> ### [`v1.10.0`](https://github.com/stretchr/testify/releases/tag/v1.10.0) [Compare Source](stretchr/testify@v1.9.0...v1.10.0) #### What's Changed ##### Functional Changes - Add PanicAssertionFunc by [@fahimbagar](https://github.com/fahimbagar) in stretchr/testify#1337 - assert: deprecate CompareType by [@dolmen](https://github.com/dolmen) in stretchr/testify#1566 - assert: make YAML dependency pluggable via build tags by [@dolmen](https://github.com/dolmen) in stretchr/testify#1579 - assert: new assertion NotElementsMatch by [@hendrywiranto](https://github.com/hendrywiranto) in stretchr/testify#1600 - mock: in order mock calls by [@ReyOrtiz](https://github.com/ReyOrtiz) in stretchr/testify#1637 - Add assertion for NotErrorAs by [@palsivertsen](https://github.com/palsivertsen) in stretchr/testify#1129 - Record Return Arguments of a Call by [@jayd3e](https://github.com/jayd3e) in stretchr/testify#1636 - assert.EqualExportedValues: accepts everything by [@redachl](https://github.com/redachl) in stretchr/testify#1586 ##### Fixes - assert: make tHelper a type alias by [@dolmen](https://github.com/dolmen) in stretchr/testify#1562 - Do not get argument again unnecessarily in Arguments.Error() by [@TomWright](https://github.com/TomWright) in stretchr/testify#820 - Fix time.Time compare by [@myxo](https://github.com/myxo) in stretchr/testify#1582 - assert.Regexp: handle \[]byte array properly by [@kevinburkesegment](https://github.com/kevinburkesegment) in stretchr/testify#1587 - assert: collect.FailNow() should not panic by [@marshall-lee](https://github.com/marshall-lee) in stretchr/testify#1481 - mock: simplify implementation of FunctionalOptions by [@dolmen](https://github.com/dolmen) in stretchr/testify#1571 - mock: caller information for unexpected method call by [@spirin](https://github.com/spirin) in stretchr/testify#1644 - suite: fix test failures by [@stevenh](https://github.com/stevenh) in stretchr/testify#1421 - Fix issue [#1662](stretchr/testify#1662) (comparing infs should fail) by [@ybrustin](https://github.com/ybrustin) in stretchr/testify#1663 - NotSame should fail if args are not pointers [#1661](stretchr/testify#1661) by [@sikehish](https://github.com/sikehish) in stretchr/testify#1664 - Increase timeouts in Test_Mock_Called_blocks to reduce flakiness in CI by [@sikehish](https://github.com/sikehish) in stretchr/testify#1667 - fix: compare functional option names for indirect calls by [@arjun-1](https://github.com/arjun-1) in stretchr/testify#1626 ##### Documantation, Build & CI - .gitignore: ignore "go test -c" binaries by [@dolmen](https://github.com/dolmen) in stretchr/testify#1565 - mock: improve doc by [@dolmen](https://github.com/dolmen) in stretchr/testify#1570 - mock: fix FunctionalOptions docs by [@snirye](https://github.com/snirye) in stretchr/testify#1433 - README: link out to the excellent testifylint by [@brackendawson](https://github.com/brackendawson) in stretchr/testify#1568 - assert: fix typo in comment by [@JohnEndson](https://github.com/JohnEndson) in stretchr/testify#1580 - Correct the EventuallyWithT and EventuallyWithTf example by [@JonCrowther](https://github.com/JonCrowther) in stretchr/testify#1588 - CI: bump softprops/action-gh-release from 1 to 2 by [@dependabot](https://github.com/dependabot) in stretchr/testify#1575 - mock: document more alternatives to deprecated AnythingOfTypeArgument by [@dolmen](https://github.com/dolmen) in stretchr/testify#1569 - assert: Correctly document EqualValues behavior by [@brackendawson](https://github.com/brackendawson) in stretchr/testify#1593 - fix: grammar in godoc by [@miparnisari](https://github.com/miparnisari) in stretchr/testify#1607 - .github/workflows: Run tests for Go 1.22 by [@HaraldNordgren](https://github.com/HaraldNordgren) in stretchr/testify#1629 - Document suite's lack of support for t.Parallel by [@brackendawson](https://github.com/brackendawson) in stretchr/testify#1645 - assert: fix typos in comments by [@alexandear](https://github.com/alexandear) in stretchr/testify#1650 - mock: fix doc comment for NotBefore by [@alexandear](https://github.com/alexandear) in stretchr/testify#1651 - Generate better comments for require package by [@Neokil](https://github.com/Neokil) in stretchr/testify#1610 - README: replace Testify V2 notice with [@dolmen](https://github.com/dolmen)'s V2 manifesto by [@hendrywiranto](https://github.com/hendrywiranto) in stretchr/testify#1518 #### New Contributors - [@fahimbagar](https://github.com/fahimbagar) made their first contribution in stretchr/testify#1337 - [@TomWright](https://github.com/TomWright) made their first contribution in stretchr/testify#820 - [@snirye](https://github.com/snirye) made their first contribution in stretchr/testify#1433 - [@myxo](https://github.com/myxo) made their first contribution in stretchr/testify#1582 - [@JohnEndson](https://github.com/JohnEndson) made their first contribution in stretchr/testify#1580 - [@JonCrowther](https://github.com/JonCrowther) made their first contribution in stretchr/testify#1588 - [@miparnisari](https://github.com/miparnisari) made their first contribution in stretchr/testify#1607 - [@marshall-lee](https://github.com/marshall-lee) made their first contribution in stretchr/testify#1481 - [@spirin](https://github.com/spirin) made their first contribution in stretchr/testify#1644 - [@ReyOrtiz](https://github.com/ReyOrtiz) made their first contribution in stretchr/testify#1637 - [@stevenh](https://github.com/stevenh) made their first contribution in stretchr/testify#1421 - [@jayd3e](https://github.com/jayd3e) made their first contribution in stretchr/testify#1636 - [@Neokil](https://github.com/Neokil) made their first contribution in stretchr/testify#1610 - [@redachl](https://github.com/redachl) made their first contribution in stretchr/testify#1586 - [@ybrustin](https://github.com/ybrustin) made their first contribution in stretchr/testify#1663 - [@sikehish](https://github.com/sikehish) made their first contribution in stretchr/testify#1664 - [@arjun-1](https://github.com/arjun-1) made their first contribution in stretchr/testify#1626 **Full Changelog**: stretchr/testify@v1.9.0...v1.10.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever MR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this MR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).

This MR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [github.com/stretchr/testify](https://github.com/stretchr/testify) | require | minor | `v1.9.0` -> `v1.10.0` | --- ### Release Notes <details> <summary>stretchr/testify (github.com/stretchr/testify)</summary> ### [`v1.10.0`](https://github.com/stretchr/testify/releases/tag/v1.10.0) [Compare Source](stretchr/testify@v1.9.0...v1.10.0) #### What's Changed ##### Functional Changes - Add PanicAssertionFunc by [@fahimbagar](https://github.com/fahimbagar) in stretchr/testify#1337 - assert: deprecate CompareType by [@dolmen](https://github.com/dolmen) in stretchr/testify#1566 - assert: make YAML dependency pluggable via build tags by [@dolmen](https://github.com/dolmen) in stretchr/testify#1579 - assert: new assertion NotElementsMatch by [@hendrywiranto](https://github.com/hendrywiranto) in stretchr/testify#1600 - mock: in order mock calls by [@ReyOrtiz](https://github.com/ReyOrtiz) in stretchr/testify#1637 - Add assertion for NotErrorAs by [@palsivertsen](https://github.com/palsivertsen) in stretchr/testify#1129 - Record Return Arguments of a Call by [@jayd3e](https://github.com/jayd3e) in stretchr/testify#1636 - assert.EqualExportedValues: accepts everything by [@redachl](https://github.com/redachl) in stretchr/testify#1586 ##### Fixes - assert: make tHelper a type alias by [@dolmen](https://github.com/dolmen) in stretchr/testify#1562 - Do not get argument again unnecessarily in Arguments.Error() by [@TomWright](https://github.com/TomWright) in stretchr/testify#820 - Fix time.Time compare by [@myxo](https://github.com/myxo) in stretchr/testify#1582 - assert.Regexp: handle \[]byte array properly by [@kevinburkesegment](https://github.com/kevinburkesegment) in stretchr/testify#1587 - assert: collect.FailNow() should not panic by [@marshall-lee](https://github.com/marshall-lee) in stretchr/testify#1481 - mock: simplify implementation of FunctionalOptions by [@dolmen](https://github.com/dolmen) in stretchr/testify#1571 - mock: caller information for unexpected method call by [@spirin](https://github.com/spirin) in stretchr/testify#1644 - suite: fix test failures by [@stevenh](https://github.com/stevenh) in stretchr/testify#1421 - Fix issue [#1662](stretchr/testify#1662) (comparing infs should fail) by [@ybrustin](https://github.com/ybrustin) in stretchr/testify#1663 - NotSame should fail if args are not pointers [#1661](stretchr/testify#1661) by [@sikehish](https://github.com/sikehish) in stretchr/testify#1664 - Increase timeouts in Test_Mock_Called_blocks to reduce flakiness in CI by [@sikehish](https://github.com/sikehish) in stretchr/testify#1667 - fix: compare functional option names for indirect calls by [@arjun-1](https://github.com/arjun-1) in stretchr/testify#1626 ##### Documantation, Build & CI - .gitignore: ignore "go test -c" binaries by [@dolmen](https://github.com/dolmen) in stretchr/testify#1565 - mock: improve doc by [@dolmen](https://github.com/dolmen) in stretchr/testify#1570 - mock: fix FunctionalOptions docs by [@snirye](https://github.com/snirye) in stretchr/testify#1433 - README: link out to the excellent testifylint by [@brackendawson](https://github.com/brackendawson) in stretchr/testify#1568 - assert: fix typo in comment by [@JohnEndson](https://github.com/JohnEndson) in stretchr/testify#1580 - Correct the EventuallyWithT and EventuallyWithTf example by [@JonCrowther](https://github.com/JonCrowther) in stretchr/testify#1588 - CI: bump softprops/action-gh-release from 1 to 2 by [@dependabot](https://github.com/dependabot) in stretchr/testify#1575 - mock: document more alternatives to deprecated AnythingOfTypeArgument by [@dolmen](https://github.com/dolmen) in stretchr/testify#1569 - assert: Correctly document EqualValues behavior by [@brackendawson](https://github.com/brackendawson) in stretchr/testify#1593 - fix: grammar in godoc by [@miparnisari](https://github.com/miparnisari) in stretchr/testify#1607 - .github/workflows: Run tests for Go 1.22 by [@HaraldNordgren](https://github.com/HaraldNordgren) in stretchr/testify#1629 - Document suite's lack of support for t.Parallel by [@brackendawson](https://github.com/brackendawson) in stretchr/testify#1645 - assert: fix typos in comments by [@alexandear](https://github.com/alexandear) in stretchr/testify#1650 - mock: fix doc comment for NotBefore by [@alexandear](https://github.com/alexandear) in stretchr/testify#1651 - Generate better comments for require package by [@Neokil](https://github.com/Neokil) in stretchr/testify#1610 - README: replace Testify V2 notice with [@dolmen](https://github.com/dolmen)'s V2 manifesto by [@hendrywiranto](https://github.com/hendrywiranto) in stretchr/testify#1518 #### New Contributors - [@fahimbagar](https://github.com/fahimbagar) made their first contribution in stretchr/testify#1337 - [@TomWright](https://github.com/TomWright) made their first contribution in stretchr/testify#820 - [@snirye](https://github.com/snirye) made their first contribution in stretchr/testify#1433 - [@myxo](https://github.com/myxo) made their first contribution in stretchr/testify#1582 - [@JohnEndson](https://github.com/JohnEndson) made their first contribution in stretchr/testify#1580 - [@JonCrowther](https://github.com/JonCrowther) made their first contribution in stretchr/testify#1588 - [@miparnisari](https://github.com/miparnisari) made their first contribution in stretchr/testify#1607 - [@marshall-lee](https://github.com/marshall-lee) made their first contribution in stretchr/testify#1481 - [@spirin](https://github.com/spirin) made their first contribution in stretchr/testify#1644 - [@ReyOrtiz](https://github.com/ReyOrtiz) made their first contribution in stretchr/testify#1637 - [@stevenh](https://github.com/stevenh) made their first contribution in stretchr/testify#1421 - [@jayd3e](https://github.com/jayd3e) made their first contribution in stretchr/testify#1636 - [@Neokil](https://github.com/Neokil) made their first contribution in stretchr/testify#1610 - [@redachl](https://github.com/redachl) made their first contribution in stretchr/testify#1586 - [@ybrustin](https://github.com/ybrustin) made their first contribution in stretchr/testify#1663 - [@sikehish](https://github.com/sikehish) made their first contribution in stretchr/testify#1664 - [@arjun-1](https://github.com/arjun-1) made their first contribution in stretchr/testify#1626 **Full Changelog**: stretchr/testify@v1.9.0...v1.10.0 </details> --- - [ ] If you want to rebase/retry this MR, check this box ---    See merge request alpine/infra/build-server-status!18

hendrywiranto force-pushed the adjust-readme-remove-v2 branch from f428650 to b48f25e Compare January 6, 2024 17:12

hendrywiranto changed the title ~~Remove Testify V2 notice on readme since it won't happen~~ Replace Testify V2 notice with maintainer's V2 manifesto on readme Jan 9, 2024

hendrywiranto force-pushed the adjust-readme-remove-v2 branch from dac4a1b to d370c30 Compare January 10, 2024 16:03

hendrywiranto force-pushed the adjust-readme-remove-v2 branch from d370c30 to 3b4b536 Compare February 21, 2024 15:38

brackendawson requested changes Feb 21, 2024

View reviewed changes

dolmen added the documentation label Mar 7, 2024

dolmen changed the title ~~Replace Testify V2 notice with maintainer's V2 manifesto on readme~~ README: replace Testify V2 notice with maintainer's V2 manifesto Mar 7, 2024

dolmen changed the title ~~README: replace Testify V2 notice with maintainer's V2 manifesto~~ README: replace Testify V2 notice with @dolmen's V2 manifesto Mar 7, 2024

dolmen mentioned this pull request May 16, 2024

Running Parallel Tests in Suite #187

Open

brackendawson requested changes Sep 29, 2024

View reviewed changes

brackendawson mentioned this pull request Sep 29, 2024

Using generics #1147

Closed

hendrywiranto added 2 commits October 26, 2024 23:18

link maintainer manifesto on readme instead of v2 notice

8f049b0

review: use proper github md

2780579

hendrywiranto force-pushed the adjust-readme-remove-v2 branch from 50edd68 to 2780579 Compare October 26, 2024 16:19

brackendawson approved these changes Oct 26, 2024

View reviewed changes

brackendawson merged commit 89352f7 into stretchr:master Oct 26, 2024
8 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

README: replace Testify V2 notice with @dolmen's V2 manifesto #1518

README: replace Testify V2 notice with @dolmen's V2 manifesto #1518

hendrywiranto commented Dec 10, 2023

Antonboom commented Dec 10, 2023

hendrywiranto commented Dec 10, 2023

dolmen commented Jan 5, 2024 •

edited

Loading

hendrywiranto commented Jan 6, 2024

Antonboom commented Jan 9, 2024

hendrywiranto commented Jan 10, 2024

MovieStoreGuy commented Jan 17, 2024

hendrywiranto commented Jan 17, 2024

brackendawson left a comment

dolmen commented Mar 5, 2024

brackendawson left a comment

brackendawson Sep 29, 2024

hendrywiranto Oct 26, 2024

		Notice about Testify V2:
		It won't happen due to various reasons. You can read more about it on the maintainer's manifesto [here](https://github.com/stretchr/testify/issues/1089#issuecomment-1812734472).

README: replace Testify V2 notice with @dolmen's V2 manifesto #1518

README: replace Testify V2 notice with @dolmen's V2 manifesto #1518

Conversation

hendrywiranto commented Dec 10, 2023

Summary

Changes

Motivation

Related issues

Antonboom commented Dec 10, 2023

hendrywiranto commented Dec 10, 2023

dolmen commented Jan 5, 2024 • edited Loading

hendrywiranto commented Jan 6, 2024

Antonboom commented Jan 9, 2024

hendrywiranto commented Jan 10, 2024

MovieStoreGuy commented Jan 17, 2024

hendrywiranto commented Jan 17, 2024

brackendawson left a comment

Choose a reason for hiding this comment

dolmen commented Mar 5, 2024

brackendawson left a comment

Choose a reason for hiding this comment

brackendawson Sep 29, 2024

Choose a reason for hiding this comment

hendrywiranto Oct 26, 2024

Choose a reason for hiding this comment

dolmen commented Jan 5, 2024 •

edited

Loading