suite: fix recoverAndFailOnPanic to report test failure at the right location #1502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dolmen
requested review from
ernesto-jimenez,
DAddYE,
mazondo,
matryer,
glesica,
mvdkleijn,
nelsam,
brackendawson,
georgelesica-wf,
boyan-soubachov and
MovieStoreGuy
and removed request for
ernesto-jimenez,
DAddYE,
mazondo,
matryer,
glesica,
mvdkleijn,
nelsam,
brackendawson,
georgelesica-wf,
boyan-soubachov and
MovieStoreGuy
dolmen
force-pushed
the
suite-fix-reporting-of-panic-location
branch
from
c685645 to
1bf48eb
Compare
MovieStoreGuy
approved these changes
Jan 17, 2024
|
Could I ask you to fix up the issues with CI? |
Add calls to t.Helper() to fix the location where the panic is reported as a test failure.
dolmen
force-pushed
the
suite-fix-reporting-of-panic-location
branch
from
1bf48eb to
2be68b5
Compare
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
#1501 shows that the panic in the test is reported in
suite.go:87which is the location of thefailOnPanicfunction. This is due to missing calls totesting.T.Helperto helptestingto skip our framework code.Changes
t.Helper()to fix the location where the panic is reported as a test failure.Motivation
Bug.
Related issues
Cc: @YaroslavDev