Skip to content

Commit

Permalink
Closes Bears-R-Us#2886: Cap small strs groupby optimization
Browse files Browse the repository at this point in the history
This PR (closes Bears-R-Us#2886) caps strs for the small str optimization at 8 bytes since there was a drop off in our str groupby benchmarks

This is because we currently have our small str optimization set to kick in at 16 bytes (which is how long the strings are in the multi-col str groupby benchmark) but this is the max number of bits we can have before we hit the totalDigits > 8 case, where we hash everything anyway. So these are all resulting in extra processing just to do what we were already doing
  • Loading branch information
Pierce Hayes committed Dec 14, 2023
1 parent b72660d commit 07a3d23
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/AryUtil.chpl
Original file line number Diff line number Diff line change
Expand Up @@ -235,7 +235,7 @@ module AryUtil
var allSmallStrs = true;
var extraArraysNeeded = 0;
var numStrings = 0;
const smallStrCap = 17; // one bigger to ignore null byte
const smallStrCap = 9; // one bigger to ignore null byte
for (name, objtype, i) in zip(names, types, 1..) {
var thisSize: int;
select objtype.toUpper(): ObjType {
Expand Down

0 comments on commit 07a3d23

Please sign in to comment.