fix issue when no src attr is provided

streetturtle · May 2, 2016 · 0a08aae · 0a08aae
1 parent 1cb423e
commit 0a08aae
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 21 deletions.
diff --git a/demo/index.html b/demo/index.html
@@ -57,17 +57,7 @@ <h3>Dynamically change PDF source</h3>
       <template>
         <paper-button raised id="one">PDF One</paper-button>
         <paper-button raised id="another">PDF Two</paper-button>
-        <pdf-element id="pdf" show-spinner  width=800 height=600></pdf-element>
-        <script>
-          window.onload = function() {
-            document.querySelector("#one").addEventListener("click", function() {
-              document.getElementById("pdf").setAttribute("src", "./pdf.pdf");
-            });
-            document.querySelector("#another").addEventListener("click", function() {
-              document.getElementById("pdf").setAttribute("src", "./example.pdf");
-            });
-          }
-        </script>
+        <pdf-element id="pdf" show-spinner width=800 height=600></pdf-element>
       </template>
       <script>
         window.onload = function() {

diff --git a/pdf-element.html b/pdf-element.html
@@ -151,7 +151,8 @@
          */
         src: {
           type: String,
-          notify: true
+          notify: true,
+          observer: '_srcChanged'
         },
         /**
          * The z-depth of this element, from 0-5. Setting to 0 will remove the shadow, and each increasing number greater than 0 will be "deeper" than the last.
@@ -200,15 +201,13 @@
         this.fileName = this.src.split('/').pop();
         this.currentPage = 1;
       },
-      attributeChanged: function(attrName, oldVal, newVal) {
-        if (attrName == 'src' && newVal != '') {
-          if (typeof this.instance == 'undefined') this._initializeReader();
-          else {
-            this.instance.changePDFSource(newVal);
-            this.currentPage = 1;
-            this.totalPages = this.instance.totalPages;
-            this.fileName = this.src.split('/').pop();
-          }
+      _srcChanged: function(newVal) {
+        if (typeof this.instance == 'undefined') this._initializeReader();
+        else {
+          this.instance.changePDFSource(newVal);
+          this.currentPage = 1;
+          this.totalPages = this.instance.totalPages;
+          this.fileName = this.src.split('/').pop();
         }
       },
       zoomIn: function() {