Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return Code of 1 when doing --version #880

Closed
4 of 18 tasks
matthewfcarlson opened this issue Jan 22, 2021 · 5 comments · Fixed by #883
Closed
4 of 18 tasks

Return Code of 1 when doing --version #880

matthewfcarlson opened this issue Jan 22, 2021 · 5 comments · Fixed by #883

Comments

@matthewfcarlson
Copy link

Info

Kind of Issue

  • runtime - command-line tools
  • building / compiling
  • security
  • change in behavior
  • crash / error

Which Tool or library

  • cspell -- the command-line spelling tool
  • cspell-tools -- used for building dictionary files
  • cspell-lib -- library that does the actual spell checking.
  • cspell-trie -- tool for working with trie files.

Which Version

Version: 5.1.2

Issue with supporting library?

  • No
  • cspell-glob -- library for matching glob patterns
  • cspell-io -- thin file i/o library
  • cspell-trie-lib - trie lib
  • cspell-trie2-lib - trie lib alternate format

OS:

  • Macos
  • Linux
  • Windows
  • Other

version:

OS version if applicable.

Bug Description

Describe the bug

A return code of 1 is returned when a zero is expected

To Reproduce

Steps to reproduce the behavior:

  1. cspell --version
  2. Check return code

Expected behavior

A return code of zero is expected. I can see commander doing this:

 this._exit(0, 'commander.version', str);

So for the life of me, I can't figure out what's going on

Screenshots

If applicable, add screenshots to help explain your problem.

Additional context

Add any other context about the problem here.

cspell.json

If applicable, attach a copy of the cspell.json file.

Example Repository (Optional)

An example repository makes things easier to debug.

@matthewfcarlson
Copy link
Author

4.10 works
4.20 does not

@Jason3S
Copy link
Collaborator

Jason3S commented Jan 22, 2021

Thank you. I'll take a look.

Jason3S added a commit that referenced this issue Jan 23, 2021
Jason3S added a commit that referenced this issue Jan 23, 2021
Jason3S added a commit that referenced this issue Jan 23, 2021
Jason3S added a commit that referenced this issue Jan 23, 2021
* fix: reduce the cost of the word splitter

* fix: #880
@matthewfcarlson
Copy link
Author

Thanks for fixing this so quickly!

@Jason3S
Copy link
Collaborator

Jason3S commented Jan 26, 2021

No worries. I use the pattern following pattern in my ci/cd scripts, so it made sense to make sure it worked with cspell.

node -v
npm -v
npm test

@github-actions
Copy link
Contributor

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants