fix: Upgrade to commend-json 4.2.2 (#2399)

streetsidesoftware · Feb 4, 2022 · e5f643e · e5f643e
1 parent a1ccfe0
commit e5f643e
Show file tree

Hide file tree

Showing 5 changed files with 27 additions and 21 deletions.
diff --git a/packages/cspell-lib/package-lock.json b/packages/cspell-lib/package-lock.json
diff --git a/packages/cspell-lib/package.json b/packages/cspell-lib/package.json
@@ -51,7 +51,7 @@
     "@cspell/cspell-bundled-dicts": "^5.18.2",
     "@cspell/cspell-types": "^5.18.2",
     "clear-module": "^4.1.2",
-    "comment-json": "^4.1.1",
+    "comment-json": "^4.2.2",
     "configstore": "^5.0.1",
     "cosmiconfig": "^7.0.1",
     "cspell-glob": "^5.18.2",

diff --git a/packages/cspell-lib/src/util/resolveFile.test.ts b/packages/cspell-lib/src/util/resolveFile.test.ts
@@ -13,7 +13,7 @@ interface Config {
 const defaultConfigFile = require.resolve('@cspell/cspell-bundled-dicts/cspell-default.json');
 const defaultConfigLocation = path.dirname(defaultConfigFile);
 
-const config: Config = parse(fs.readFileSync(defaultConfigFile, 'utf-8'));
+const config = readConfig(defaultConfigFile);
 
 const ext = path.extname(__filename);
 const notFound = '1fgh0dld6y56cr1wls.r9bp0ckc00ds0gna.json';
@@ -59,3 +59,9 @@ describe('Validate resolveFile', () => {
         expect(r.found).toBe(found);
     });
 });
+
+function readConfig(filename: string): Config {
+    const parsed = parse(fs.readFileSync(filename, 'utf-8'));
+    if (!parsed || typeof parsed !== 'object') throw new Error(`Unable to parse "${filename}"`);
+    return parsed as unknown as Config;
+}
diff --git a/packages/cspell/package-lock.json b/packages/cspell/package-lock.json
diff --git a/packages/cspell/package.json b/packages/cspell/package.json
@@ -73,7 +73,7 @@
     "@cspell/cspell-pipe": "^5.18.2",
     "chalk": "^4.1.2",
     "commander": "^9.0.0",
-    "comment-json": "^4.1.1",
+    "comment-json": "^4.2.2",
     "cspell-gitignore": "^5.18.2",
     "cspell-glob": "^5.18.2",
     "cspell-lib": "^5.18.2",