-
-
Notifications
You must be signed in to change notification settings - Fork 359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate main screen to Compose #5799
Conversation
I think no such devices were manufactured for over ten years
…StreetComplete into compose-controls
… every recomposition
I had to stop myself from ever-expanding the scope of this. I reviewed the stuff myself and tested most of the things. |
@Helium314 @FloEdelmann @matkoniecz I will soon merge this to master. If you would like to lend a hand in reviewing this before it is merged, you should do it soon. |
I kind of don't like about this work that it - necessarily - leaves so many open ends, i.e. contact points between the ViewModel+Compose code and the (old) Android Fragments/Activity code. But it is currently not possible really to reduce this while not all things the MainActivity needs to talk to are all re-done in ViewModel+Compose, as everything comes together at the MainActivity. It is also particularly hard to migrate this properly because there is so much stuff happening specific to Android. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had a cursory look over the changes (without running the app or tests) and found nothing that caught my eye.
Thanks! I took it out for a test today and found two issues that I'll try to fix today/tomorrow:
|
|
|
The second animation/video with the quest icons sliding up from below the screen but in tilted mode looks kinda uhm… tbh unprofessional /childish. I guess the actual reason for that is that it is tilted in perspective but it does not account for that in the animation. The animation is just a slide in effect from below, which would maybe work for a flat image, but not the 3d view there. IMHO this reminds me of some silly PowerPoint animations I once did. Not blaming here, just trying to make you aware of that. Especially maybe as the icons are flat and have no "depth", it looks very artificial and not "real" of you get what I mean? Or maybe animate each icon/quest at once and not in "bulk". Like dropping that animation altogether and have the icons "pop in" with some random delay and possibly location (transparency fade effect maybe with zoom), so it looks like what you seem to convey here:"quests pop up everywhere, this is too much"? |
What is migrated:
Screen-20240822-005327.mp4
toomuch.mp4
To do: