Disable restoring hidden quests when there are none to unhide. #5359
Conversation
app/src/main/java/de/westnordost/streetcomplete/data/Database.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/de/westnordost/streetcomplete/screens/settings/SettingsFragment.kt
Outdated
Show resolved
Hide resolved
jmizv
changed the title
Maybe the focus of this PR should be: "Disable the option to unhide hidden quests when there are none". And the information about the currently hidden quests is just a nice-to-have. So it is not useful per se but in combination with the disabling of the resetting it is nice to see why it is disabled (=no hidden quests). |
|
Right, okay |
I always thought it seemed a bit odd that it told you after you'd unhidden them how many would be unhidden, but not before you made the choice. It seems a nice to have, is it just doing the ten from earlier today or 200 from a few weeks/month? |
|
Conflicts in |
Your PR should not include additions to translated files. The strings will be translated later. |
Okay, conflicts and changes for that file have been removed. |
| private val osmQuestsHiddenDao: OsmQuestsHiddenDao by inject() | ||
| private val noteQuestsHiddenDao: NoteQuestsHiddenDao by inject() |
There was a problem hiding this comment.
It is uncommon (if not: not done at all) in this codebase to directly access the Daos from view code. Fragments and Activities instead access *Controllers or *Source classes to update or get data. The update of the view subsequently should be reactive to changes in the data, i.e. the quest summary should not update after having tapped the button, but instead the tapping of the button changes the data and because the data is changed, the label is updated.
I wanted to write the details but that got so involved that I rather do it myself unless you know now exactly what to do. I'll do that then otherwise shortly before the next update.
There was a problem hiding this comment.
I'd be happy if you could work on this as I don't think I'm expert enough to do it myself. Thank you!
…ces where it's just about the hidden quests
|
Alright, did this now, I also updated that one overview of classes and how they are connected, this is why the change seems to be so big counted in lines of code. In a nutshell, what I did was:
|
|
Feel free to look at my changes, you can see them here: 0ab82c5 |
The option to unhide hidden quests should be disabled when there are none to unhide.