don't execute code unnecessarily if nothing changes

streetcomplete · Apr 21, 2021 · afd4dce · afd4dce
1 parent 4618f7c
commit afd4dce
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 0 deletions.
diff --git a/app/src/main/java/de/westnordost/streetcomplete/data/osm/edits/ElementEditsController.kt b/app/src/main/java/de/westnordost/streetcomplete/data/osm/edits/ElementEditsController.kt
@@ -70,6 +70,7 @@ import javax.inject.Singleton
      *  the undo history */
     fun deleteSyncedOlderThan(timestamp: Long): Int {
         val edits = editsDB.getSyncedOlderThan(timestamp)
+        if (edits.isEmpty()) return 0
         val result = editsDB.deleteAll(edits.map { it.id })
         onDeletedEdits(edits)
         return result

diff --git a/app/src/main/java/de/westnordost/streetcomplete/data/osmnotes/edits/NoteEditsController.kt b/app/src/main/java/de/westnordost/streetcomplete/data/osmnotes/edits/NoteEditsController.kt
@@ -90,6 +90,7 @@ import javax.inject.Singleton
 
     @Synchronized fun deleteSyncedOlderThan(timestamp: Long): Int {
         val edits = editsDB.getSyncedOlderThan(timestamp)
+        if (edits.isEmpty()) return 0
         val result = editsDB.deleteAll(edits.map { it.id })
         onDeletedEdits(edits)
         return result