fix(aws): autoscaling condition key #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxsxu
changed the title
dpappa
approved these changes
May 22, 2024
maxsxu
added a commit
that referenced
this pull request
May 22, 2024
🤖 I have created a release *beep* *boop* --- ## [3.13.1](v3.13.0...v3.13.1) (2024-05-22) ### Bug Fixes * autoscaling condition key ([470011e](470011e)) * **aws:** autoscaling condition key ([#84](#84)) ([470011e](470011e)) * use wildcard dns records for brokers in Azure private endpoint module ([#82](#82)) ([0528113](0528113)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Max Xu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The actual generated ASG tag key is
eks:cluster-namerather thancluster-name.Wrong condition will block autoscaling tagging operations.
The AWS didn't explicitly tell user about this, but here are some references:
Modification
"autoscaling:ResourceTag/eks:cluster-name"