Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cloud-manager-agent as Helm Chart w/ Terraform Module #40

Merged
merged 12 commits into from
Apr 27, 2022

Conversation

jdmaguire
Copy link
Contributor

In the old way we'd configure poolmembers, we'd deploy a bunch of kustomize manifests against the cluster. We're porting them over to helm w/ terraform module. This is the work for cloud-manager-agent.

It's a pretty standard chart.

A statefulset. A headless service. Some config maps for the app.

@jdmaguire
Copy link
Contributor Author

jdmaguire commented Apr 22, 2022

Still to do:

  • top main.tf changes
  • test
  • Remove some incorrect wording
  • Generate readme

@jdmaguire
Copy link
Contributor Author

Still trying to get this working. Talking to Joey, we decided to add ExternalSecret support. That component is deprecated; I've filled tickets to upgrade to the External Secrets Operator.

streamnative/terraform-google-cloud#5
streamnative/terraform-aws-cloud#62

Trying to get this working on a test cluster with this values file:

appConfig:
  applicationAgentProperties:
    kubernetesExternalSecret:
      enabled: true

Having some issues. Just recording this all for next week.

@jdmaguire jdmaguire force-pushed the john/cloud-manager-chart-convert branch 3 times, most recently from 726825e to 9f22430 Compare April 27, 2022 16:10
@jdmaguire jdmaguire force-pushed the john/cloud-manager-chart-convert branch from 9f22430 to 1977fae Compare April 27, 2022 16:17
@jdmaguire jdmaguire marked this pull request as ready for review April 27, 2022 17:13
@jdmaguire jdmaguire requested a review from a team as a code owner April 27, 2022 17:13
@jdmaguire
Copy link
Contributor Author

This code works as-is. There is some discussion one whether we should use the secret raw, have cloud-api-server inject the secret, or use KSE/ESO. This PR could go in before that decision is made.

Copy link
Contributor

@jrsdav jrsdav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it! Great job.

@jrsdav jrsdav merged commit 4075033 into master Apr 27, 2022
@delete-merged-branch delete-merged-branch bot deleted the john/cloud-manager-chart-convert branch April 27, 2022 19:20
@jdmaguire
Copy link
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants