Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add opts for extra node pool sizes #99

Merged
merged 5 commits into from
Mar 14, 2023
Merged

Conversation

jdmaguire
Copy link
Contributor

This fixes a little gap were were were not able to explicitly set the size for the extra node pools deployed.

@jdmaguire jdmaguire requested a review from a team as a code owner March 14, 2023 14:53
@github-actions
Copy link
Contributor

@jdmaguire:Thanks for your contribution. For this PR, do we need to update docs?
(The PR template contains info about doc, which helps others know more about the changes. Can you provide doc-related info in this and future PR descriptions? Thanks)

@github-actions github-actions bot added the doc-info-missing This pr needs to mark a document option in description label Mar 14, 2023
Copy link
Contributor

@gengmao gengmao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jdmaguire jdmaguire added the doc This pr contains a document label Mar 14, 2023
@github-actions github-actions bot removed the doc-info-missing This pr needs to mark a document option in description label Mar 14, 2023
@github-actions
Copy link
Contributor

@jdmaguire:Thanks for providing doc info!

@jdmaguire jdmaguire merged commit 6610864 into release/v2.5 Mar 14, 2023
@jdmaguire jdmaguire deleted the v2.5_extra_pool_opts branch March 14, 2023 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc This pr contains a document
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants