Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support AWS China #70

Merged
merged 11 commits into from
Jun 17, 2022
Merged

Support AWS China #70

merged 11 commits into from
Jun 17, 2022

Conversation

maxsxu
Copy link
Member

@maxsxu maxsxu commented May 24, 2022

Fixes #68

Motivation

Support AWS China.

Modifications

  • Add partition in IAM bootstrap to make was partition configurable
  • Add a new IAM role binding StreamNativeCloudManagementRole trusted user/aws-cn-test. As AWS China have to use the generic authentication approach
  • Add sts.amazonaws.com to openid_connect_audiences. As applications like external-dns cannot utilize the generated sts.amazonaws.com.cn
  • Add aws-cn in validation rule at modules/vpc/variables.tf
  • Make aws partition configurable by reusing the var.aws_partition

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Documentation

Check the box below.

Need to update docs?

  • doc-required

    (If you need help on updating docs, create a doc issue)

  • no-need-doc

    (Please explain why)

  • doc

    (If this PR contains doc changes)

@github-actions
Copy link
Contributor

@maxsxu:Thanks for your contribution. For this PR, do we need to update docs?
(The PR template contains info about doc, which helps others know more about the changes. Can you provide doc-related info in this and future PR descriptions? Thanks)

@github-actions github-actions bot added the doc-info-missing This pr needs to mark a document option in description label May 24, 2022
@maxsxu maxsxu marked this pull request as ready for review June 9, 2022 13:51
@maxsxu maxsxu requested a review from a team as a code owner June 9, 2022 13:51
@jrsdav
Copy link
Contributor

jrsdav commented Jun 13, 2022

This looks good to me, just note that PR #72 brought in some changes to the managed-cloud module, in particular a new set of *-runtime.json.tpl files that will need the var.partition interpolation.

jrsdav
jrsdav previously approved these changes Jun 16, 2022
Copy link
Contributor

@jrsdav jrsdav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, very thorough. Thanks @maxsxu!

@maxsxu maxsxu merged commit 34cf3ce into master Jun 17, 2022
@delete-merged-branch delete-merged-branch bot deleted the max/aws-cn branch June 17, 2022 05:33
@maxsxu maxsxu added doc-required This pr needs a document and removed doc-info-missing This pr needs to mark a document option in description labels Jun 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc-required This pr needs a document
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support AWS China
3 participants