Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missing parameters in root-example #58

Merged
merged 1 commit into from
Mar 28, 2022
Merged

Fix missing parameters in root-example #58

merged 1 commit into from
Mar 28, 2022

Conversation

maxsxu
Copy link
Member

@maxsxu maxsxu commented Mar 28, 2022

Fixes #57

Motivation

The examples/root-example cannot run because of missing parameters.

Modifications

Add missing parameters.

Verifying this change

  • Make sure that the change passes the CI checks.

This change added tests and can be verified as follows:

  • Execute terraform plan under examples/root-example

Documentation

  • no-need-doc

@github-actions github-actions bot added the no-need-doc This pr does not need any document label Mar 28, 2022
@maxsxu maxsxu requested review from jrsdav and fantapsody March 28, 2022 15:11
@jrsdav jrsdav merged commit e98dd55 into master Mar 28, 2022
@delete-merged-branch delete-merged-branch bot deleted the max/fix-examples branch March 28, 2022 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrsdav jrsdav jrsdav approved these changes

@fantapsody fantapsody Awaiting requested review from fantapsody

Assignees

@maxsxu maxsxu

Labels
no-need-doc This pr does not need any document
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot run the root-example
2 participants
@maxsxu @jrsdav