[managed-cloud] Policy and module updates; Support for CloudFormation #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
addisonj
reviewed
Jan 8, 2022
| - !Ref ControlPlaneManagerArn | ||
| - !Ref VendorSupportRoleArn | ||
| Action: sts:AssumeRole | ||
| - Sid: AllowStreamNativeControlPlaneAccess |
There was a problem hiding this comment.
I don't think we need this here, as the access first comes from the our AWS account, not direct from the control plane cluster
addisonj
reviewed
Jan 8, 2022
| Principal: | ||
| AWS: | ||
| - !Ref ControlPlaneManagerArn | ||
| - !Ref VendorSupportRoleArn |
There was a problem hiding this comment.
My thinking is we can still just use a single ARN as trust, as we can just grant go through control plane ARN
jrsdav
changed the title
|
TODO:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a CloudFormation template to the
managed-cloudmodule, as an alternative method of deploying the resources used for StreamNative's vendor access.Additional policy updates have been made to the
managed-cloudmodule to support access by StreamNative's Control Plane for Cloud Managed environments.