Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add new variables for forward compatibility #142

Merged
merged 2 commits into from
Nov 3, 2024
Merged

Conversation

maxsxu
Copy link
Member

@maxsxu maxsxu commented Oct 28, 2024

Motivation

It's for support forward compatibility of PR #140, so old existing module caller won't broken.

This PR will be v3.3.0, and the PR #140 will be v4.0.0

Modifications

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Documentation

  • doc

Copy link
Contributor

@maxsxu:Thanks for your contribution. For this PR, do we need to update docs?
(The PR template contains info about doc, which helps others know more about the changes. Can you provide doc-related info in this and future PR descriptions? Thanks)

@github-actions github-actions bot added the doc-info-missing This pr needs to mark a document option in description label Oct 28, 2024
@maxsxu maxsxu marked this pull request as ready for review November 1, 2024 10:52
@maxsxu maxsxu requested a review from a team as a code owner November 1, 2024 10:52
@github-actions github-actions bot removed the doc-info-missing This pr needs to mark a document option in description label Nov 1, 2024
Copy link
Contributor

github-actions bot commented Nov 1, 2024

@maxsxu:Thanks for providing doc info!

@github-actions github-actions bot added the doc This pr contains a document label Nov 1, 2024
@maxsxu maxsxu merged commit 269b38f into master Nov 3, 2024
7 checks passed
@maxsxu maxsxu deleted the max/v3-comp branch November 3, 2024 06:08
maxsxu pushed a commit that referenced this pull request Nov 4, 2024
🤖 I have created a release *beep* *boop*
---


##
[3.3.0](v3.2.0...v3.3.0)
(2024-11-03)


### Features

* add new variables for forward compatibility
([#142](#142))
([269b38f](269b38f))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc This pr contains a document
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants