feat(coordinator): support update service info when config changed #561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattisonchao
requested review from
merlimat,
coderzc and
RobertIndie
as code owners
mattisonchao
force-pushed
the
feat.service.info.update.c
branch
from
1d25c6e to
6697e6f
Compare
mattisonchao
changed the title
merlimat
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
In practice, we might want to update the service public address for the existing cluster for some reason. This PR supports the functionalities by identifying the internal address as a logical node ID and updating the public address when the new term is used.
also, we can introduce a node Id that can help us update the internal address or other information introduced in the future.
Modification
newTermsafe point.internalAddressas the logical node id.